search

siemens / kas

Setup tool for bitbake based projects
MIT License
339 stars 145 forks source link

Improve containerized codecommit support. #106

Open liambeguin opened 8 months ago

jan-kiszka commented 8 months ago

Thanks for your contribution. But could you be a bit more verbose in your descriptions?

Already the very first patch leaves me a bit clueless why exactly this this is now needed with this codecommit. But also what codecommit is (some link?), why one want this, that is also missing, e.g. in patch series header / PR description.

For a broader discussion, it would be good to send the series via git send-email to our mailing list.

liambeguin commented 8 months ago

Hi @jan-kiszka,

Thanks for taking a look at this. Apologies for not adding more context to the description. I was going to come back to it and forgot somehow. I did assume codecommit was known by some though as it's already partially supported.

I apologize also for not sending to the mailing list, I overlooked the CONTRIBUTING document. I'll rework and send there.

Should we consider disabling github PR on the repo if the mailing list is the preferred way?

jan-kiszka commented 4 months ago

I don't remember any follow-ups - were there any?

Regarding PRs: I don't think this can be disabled on GH (in contrast to gitlab).