search

siemens / kas

Setup tool for bitbake based projects
MIT License
339 stars 145 forks source link

.netrc should not contain comments #111

Closed adamjohnstonarm closed 3 months ago

adamjohnstonarm commented 3 months ago

A recent change to OE core causes bitbake to fallback to netrc when BB_HASHSERVE_USERNAME or BB_HASHSERVE_PASSWORD are not set.

This exposes us to an error when running in GitLab because kas has been inserting a comment into ~/.netrc.

# appended by kas, you have gitlab CI env

Resulting in...

netrc.NetrcParseError: bad toplevel token 'appended'

The comment should not be added is it relies on undocumented behaviour.

adamjohnstonarm commented 3 months ago

Fix sent to mailing list

jonmason commented 3 months ago

Can we get this in a tagged release, as we're having to carry a patch in our CI to work around it? Perhaps 4.3.2.

jan-kiszka commented 3 months ago

Working towards this, should appear this week.

fmoessbauer commented 3 months ago

We now have the 4.3.2 release, which includes the fix. By that, we can close this issue. @jan-kiszka