search

siemens / kas

Setup tool for bitbake based projects
MIT License
382 stars 152 forks source link

GitRepo fetch_cmd shouldn't default to "git fetch --all" #18

Closed NGenetzky closed 4 years ago

NGenetzky commented 4 years ago

The fetch() method for git will call git fetch --all ; this causes issues because I have 12+ forks added as remotes for one of my layers. It seems like this should be able to only fetch 'origin', which has been created by kas.

class GitRepo(RepoImpl):
    """
        Provides the git functionality for a Repo.
    """
...
    def fetch_cmd(self):
        return ['git', 'fetch', '--all']
jan-kiszka commented 4 years ago

Valid remark. I do not find any reason for the --all in the git histories.

Would you like to send this as patch with reasoning to kas-devel?

igaw commented 4 years ago

My bad, it's my usual thing I do in the morning and I added it as command to kas.

NGenetzky commented 4 years ago

Would you like to send this as patch with reasoning to kas-devel?

I can, but it won't be immediate. I am still kind of new to the old school patch emailing collaboration approach.

jan-kiszka commented 4 years ago

As the new-school web-based PR mechanisms are not inclusive to people that only work via mail clients, we have to restrict us to a single channel. I'd love to work with a platform that allows both ways, but neither github nor gitlab support that.

However, I can forward simple PRs to the list. Just make sure the commit is properly formatted (subject, message, signed-off - see https://github.com/siemens/kas/blob/master/CONTRIBUTING.md).

NGenetzky commented 4 years ago

Mailing list (xiUoNPQ0IaU)

3 NGenetzky commented on xiUoNPQ0IaU

Submitting patch for review.

jan-kiszka commented 4 years ago

Applied to next.