search

siemens / kas

Setup tool for bitbake based projects
MIT License
353 stars 144 forks source link

Apply patches before doing an environment setup #47

Closed phatina closed 3 years ago

phatina commented 3 years ago

We may need to patch the environment setup, too.

A project I am working on for a specific reason can not (for now) update to a newer Yocto release. There's a problem with Python2 and current GNU/Linux distros. We need to apply a tiny patch for the internals there. This needs to happen before SetupEnviron().

Thanks.

jan-kiszka commented 3 years ago

Same remark as on your other PR: Needs a round via the ML to get everyone's attention.

phatina commented 3 years ago

Thanks for the review. Moved SetupEnviron() below ReposApplyPatches(). I tested it without ~/.gitconfig and then kas checkout failed. This works for me then.

phatina commented 3 years ago

What about this Pull Request? Close it as applied? In case I have a new change, shall I target next branch?

jan-kiszka commented 3 years ago

Can be closed as the patch is in next at least.

New patches on top of next, yes. We do not need to track them in PRs when sent to the list.