search

siemens / kas

Setup tool for bitbake based projects
MIT License
353 stars 144 forks source link

container-entrypoint not shellchecked #67

Closed HerrMuellerluedenscheid closed 2 years ago

HerrMuellerluedenscheid commented 2 years ago

Apparently shellcheck is not executed on container-entrypoint. I'll open a MR closing this issue if I have the time later on.

(side note: linking issues to MRs is a quite neat thing for the workflow as it's all happening on the same platform. TBH I really don't understand why you would rather make users use google for that... I mean... GOOGLE?)

jan-kiszka commented 2 years ago

We don't use google, we use email to be inclusive to the original kas community. Unfortunately, no one invented a smooth solution to use both tools (forge + email) so far, although many tried, futilely.

You can reference a github issue in your patch, of course, saying it 'Closes #XX'. That has nothing to do with how you submit your patch.

PS: So you prefer MICROSOFT over GOOGLE? :wink:

HerrMuellerluedenscheid commented 2 years ago

PS: So you prefer MICROSOFT over GOOGLE? 😉

... ahm, right, haven't thought about that 😊 Fair enough.