search

siemens / kas

Setup tool for bitbake based projects
MIT License
371 stars 148 forks source link

Fixes for nixos and other system where dependencies not install system wide #93

Closed jraygauthier closed 6 months ago

jraygauthier commented 1 year ago

Allow this tool to run on nixos systems and fixes issue when git is not installed system wide on other systems.

jan-kiszka commented 1 year ago

Thank you for the patches. Please have a look at https://github.com/siemens/kas/blob/master/CONTRIBUTING.md, specifically regarding the signed-off and how to submit patches for review.

henning-schild commented 1 year ago

@michaeladler

the contributor did not send this to the list, maybe you see value here

jan-kiszka commented 1 year ago

The key problem is that I can't merge contributions without DCO, for all of their pieces, i.e. even if someone else picks them up and continues on the list.

michaeladler commented 1 year ago

Yeah I do see value in these patches, so getting a DCO from @jraygauthier would be nice. (Although I'm on NixOS, I run kas within a container, though.)

jraygauthier commented 1 year ago

Hi @jan-kiszka and @michaeladler, sorry for the delay. I can sign-off the commits without problem and provide a DCO. How do I proceed for the DCO?

jraygauthier commented 1 year ago

Done for the sign-off.

jraygauthier commented 1 year ago

Ok, I just saw the https://github.com/siemens/kas/blob/master/CONTRIBUTING.md#developers-certificate-of-origin-11 about the DCO. Reading that, I understand that signing-off is all that is required.

jraygauthier commented 1 year ago

@michaeladler : Reading through the contribution page, I just submitted the patches to the mailing list adding you as CC.

jraygauthier commented 1 year ago

Ref to the mailing list patch set for tracking and future references: https://groups.google.com/g/kas-devel/c/UGL6AEphCyo.

Alan01252 commented 1 year ago

Fellow nix user here, would be great to get this merged, is there anything else that needs doing?

michaeladler commented 1 year ago

I'm not a maintainer but I just did a review of the patch on the mailing list (thereby reviving it).

jan-kiszka commented 1 year ago

We would still need a rebase of the series and posting of that to the mailing list in order to get this done, see also https://groups.google.com/g/kas-devel/c/UGL6AEphCyo/m/Ek24Yc4WAQAJ.

jan-kiszka commented 7 months ago

Any follow-ups planned?

jraygauthier commented 6 months ago

Any follow-ups planned?

I would personally close this PR, I lost interest in this work. If anyone want to take over, feel free to do so.