search

siemens / linux-entra-sso

Browser plugin for Linux to SSO on Microsoft Entra ID using a locally running microsoft identity broker (Intune).
Mozilla Public License 2.0
68 stars 8 forks source link

Add GitHub Actions build.yml workflow #2

Closed AdrianDsg closed 4 months ago

AdrianDsg commented 4 months ago

fix #1

fmoessbauer commented 4 months ago

Thanks for this contribution. Before we can merge this, please adapt it to the requirements stated in the CONTRIBUTING.md guide. Mainly:

Further, why do you limit the CI to the main branch? It would be good to always run it (after approval by a maintainer). Otherwise we will only discover issues once already merged.

jan-kiszka commented 4 months ago

FWIW, I've requested to add the DCO app to this repo. We are using it elsewhere already.

jan-kiszka commented 4 months ago

FWIW, I've requested to add the DCO app to this repo. We are using it elsewhere already.

And it works :laughing:

AdrianDsg commented 4 months ago

As mentioned in the commits above I removed the surplus GitLab pipeline.

To ease future contributions it might be a good idea to actually mention the license header in CONTRIBUTING.md. Since this is not a Siemens internal project not everybody might be aware of this requirement.

btw. my commit was already sign-off only with GitHub's signature since GitHub.com always signs off my commits. That might also be a nice addition.

jan-kiszka commented 4 months ago

Signing != signed-off-by tag. Your first commit has something like that, but with a pseudo email. git commit --amend -s, making sure that your local git configuration carries the right email address.

AdrianDsg commented 4 months ago

Signing != signed-off-by tag. Your first commit has something like that, but with a pseudo email. git commit --amend -s, making sure that your local git configuration carries the right email address.

well great to learn that. so I publish my business email to the internet for every spammer around. I think I rather hand this PR over instead.

bufferoverflow commented 4 months ago

I will create a new MR based on this with my email.