search

siemens / meta-iot2050

SIMATIC IOT2050 Isar/Debian Board Support Package
MIT License
131 stars 77 forks source link

Chao/m2 development #243

Closed AsuraZeng closed 2 years ago

AsuraZeng commented 2 years ago

currently,our m.2 board is not ready implement the software function firstly. pls help to review

jan-kiszka commented 2 years ago

Looks like patch 4 became outdated - no longer doing what it claims to (adding symbol).

AsuraZeng commented 2 years ago

Looks like patch 4 became outdated - no longer doing what it claims to (adding symbol).

OK，I will remove this patch and see what happens

AsuraZeng commented 2 years ago

Looks like patch 4 became outdated - no longer doing what it claims to (adding symbol).

I have tested it. adding symbol is necessary. lacking of this. it couldn't apply the dtbo. error log:

failed on fdt_overlay_apply(): FDT_ERR_NOTFOUND
base fdt does did not have a /__symbols__ node
make sure you've compiled with -@
ERROR: Did not find a cmdline Flattened Device Tree
Could not find a valid device tree
SCRIPT FAILED: continuing...
libfdt fdt_check_header(): FDT_ERR_BADMAGIC
AsuraZeng commented 2 years ago

has completed the rebase works. Add the feature to load different m2 configurations in the environment of secure UEFI

AsuraZeng commented 2 years ago

@jan-kiszka hi jan, do you have any comments ? if no, we would merge this request

jan-kiszka commented 2 years ago

Ok, now you are backporting a lot of DT binding patches just to add ours. Let's focus with that part on the important upstream step that should come along with this series. For the backported series, we can then live with having the binding docs not updated.

...provided that this kernel does not validate its dts files against the bindings which is still true for 5.10 IIRC.

Anyway, please also provide / submit the kernel patches against latest upstream so that they will be part of 5.20 ideally. Happy to help with reviewing them as well.

AsuraZeng commented 2 years ago

Ok, now you are backporting a lot of DT binding patches just to add ours. Let's focus with that part on the important upstream step that should come along with this series. For the backported series, we can then live with having the binding docs not updated.

...provided that this kernel does not validate its dts files against the bindings which is still true for 5.10 IIRC.

Anyway, please also provide / submit the kernel patches against latest upstream so that they will be part of 5.20 ideally. Happy to help with reviewing them as well.

temporary removed the backport DT binging patches from our repo. we would consider to submit the kernel or u-boot patches to the upstream when we pass the system testing.