search

siemens / meta-iot2050

SIMATIC IOT2050 Isar/Debian Board Support Package
MIT License
130 stars 79 forks source link

Refactoring configuration tool #309

Closed AsuraZeng closed 1 year ago

AsuraZeng commented 2 years ago

Add multithreaded execution logic placed in the background without blocking the UI

Signed-off-by: chao zeng chao.zeng@siemens.com

AsuraZeng commented 2 years ago

Currently in self-testing

jan-kiszka commented 2 years ago

Are these two changes in one commit, or is the serial configuration really that tightly coupled to threading?

jan-kiszka commented 2 years ago

BTW, the CI failure looks like an unrelated github connectivity issue. Maybe retry - e.g. when you have a split-up series.

AsuraZeng commented 2 years ago

Are these two changes in one commit, or is the serial configuration really that tightly coupled to threading?

yes. I have sepreated this into two commits. pls help to review.

AsuraZeng commented 2 years ago

@jan-kiszka I tested it and currently found no problems. Do you have any comments?

BaochengSu commented 2 years ago

This patch is planed to merge into the master after V1.3.1 release.

BaochengSu commented 1 year ago

@AsuraZeng Please rebase on the latest master.

AsuraZeng commented 1 year ago

transfer to draft. still needs some refines

AsuraZeng commented 1 year ago

@jan-kiszka @BaochengSu hi, do there any new comments regarding this topic?

BaochengSu commented 1 year ago 
iot2050setup: Abstract serval class to management different utility
Add different class to management different utility.

Fix the typo and grammar error of the commit message.

BaochengSu commented 1 year ago

Does the version number printable on device for both the swithserial and iot2050setup?

AsuraZeng commented 1 year ago

Does the version number printable on device for both the swithserial and iot2050setup?

It cannot be printed at this time. could use dpkg to show deb package version

AsuraZeng commented 1 year ago

@jan-kiszka hi, jan. do you have any comments regarding this PR?

jan-kiszka commented 1 year ago

Maybe just one refactoring suggestion: As patch 6 breaks bisection, and it takes patch 7 changing another tool, why not driving both the generation of the board config as well as the application out of iot2050setup modules? Maybe add a headless mode of iot2050setup to apply the config?

AsuraZeng commented 1 year ago

Maybe just one refactoring suggestion: As patch 6 breaks bisection, and it takes patch 7 changing another tool, why not driving both the generation of the board config as well as the application out of iot2050setup modules? Maybe add a headless mode of iot2050setup to apply the config?

@jan-kiszka hi,jan. Have already modified it, pls help to review it. thanks a lot.