search

siemens / meta-iot2050

SIMATIC IOT2050 Isar/Debian Board Support Package
MIT License
130 stars 79 forks source link

Improved README.md and CONTRIBUTING.md #325

Closed robang74 closed 2 years ago

robang74 commented 2 years ago

Just a tip to add in the README.md, which might be useful for those are not used to use docker/containers. Without this suggestion, the user at its first try will receive a permission error. Trying to run the script as root, it will be said to do not do that.

jan-kiszka commented 2 years ago

Please have a look at https://github.com/siemens/meta-iot2050/blob/master/CONTRIBUTING.md to resolve the DCO error. Change makes sense to me otherwise.

robang74 commented 2 years ago

Now commit e0b8675 has been signed-off properly.

jan-kiszka commented 2 years ago

Please rebase over master and fold into a single commit again. You can force-push the result here. We can also discuss the steps later if you are not familiar with git.

robang74 commented 2 years ago

Thanks, Jan. I did. I also added another commit for adding a tip also in CONTRIBUTING.md

BaochengSu commented 2 years ago

@robang74 I think everything else LGTM, except as Jan mentioned, please rebase all the commits to a single one.

After that I think this PR could be approved & merged.

robang74 commented 2 years ago

@BaochengSu: all changes has been merged into a single commit 39c07ef as requested.