integrate docker support

siemens / meta-iot2050

SIMATIC IOT2050 Isar/Debian Board Support Package

MIT License

129 stars 76 forks source link

integrate docker support #373

Closed AsuraZeng closed 1 year ago

AsuraZeng commented 1 year ago

For now, I want to make the software configurable and optional. At present, the preinstalled software and some of our custom software have been made configurable

It's still a draft, Please help to review whether this approach is appropriate

AsuraZeng commented 1 year ago

@jan-kiszka @BaochengSu
currently, this PR is ready for review. pls help to review and add your comments. thanks a lot

AsuraZeng commented 1 year ago

@jan-kiszka hi jan.do you any comments on this PR?

jan-kiszka commented 1 year ago

Four things:

We already do feature / package control in meta-iot2050. Why did you deviate from that pattern?
Please provide some reasoning why each of those features should be controllable. It's obvious for heavy stuff like docker, but why controlling 32-bit support?
IOT2050_DEBIAN_DEBUG_PACKAGES vs. IOT2050_BASIC_SOFTWARE_SUPPORT - does not sound like being the same thing.
defaults differ in Kconfig vs. image recipe

AsuraZeng commented 1 year ago

Hi jan 1.Do you mean using the install or pre-install do package control?

except for docker, could we customize our image easily? for other software, we can select using the menu not to modify the code.
For the naming can be described more concreate.
As google coral support, using kconfig also can differ with image recipe, I think kconfig is a select tool not only for the build starts.

jan-kiszka commented 1 year ago

The existing pattern is to have kas options fragment and select them in the kconfig. And there are also related entries in the menu that you didn't put into the same category now.

AsuraZeng commented 1 year ago

if every item has correspond kas yml, the kas menu is just a front end of build system. if we'd like to control all the packages, there must many correspond yml files.

Can kas menu be separated from kas yml ? Selecting through the menu interface is more intuitive for some users If we want to make software controllable, is there any elegant way?

jan-kiszka commented 1 year ago

Yes, this does not scale very well - and it relates to the discussion of what to make configurable at all. If you start adding a menu item for each possible package, kconfig will not scale either.

AsuraZeng commented 1 year ago

I think it is necessary to consider the value of doing this. If a variant of IOT only needs some software Is there a better way to integrate different software by compiling For example, if I don't want to use mraa node red etc . We can't easily get different image.

I agree with you. maybe there needs more discussion. For the docker, its too heavy, for current just making docker controllable is a acceptable way.

jan-kiszka commented 1 year ago

Ack. So, maybe just add docker for now, using the existing scheme for Coral etc., just make it opt-in. Then we can discuss other features on top.

AsuraZeng commented 1 year ago

@jan-kiszka Has already refine this PR, pls help to review.

AsuraZeng commented 1 year ago

Looks good, I would just call the option file docker.yml - shorter.

OK, has changed