search

siemens / meta-iot2050

SIMATIC IOT2050 Isar/Debian Board Support Package
MIT License
129 stars 76 forks source link

Catch up icssg driver #374

Closed AsuraZeng closed 1 year ago

AsuraZeng commented 1 year ago

this helps the issue #368 referred. after several times reboots, the ethernet port can not work.

jan-kiszka commented 1 year ago

Already asked this in firmware context, but it equally applied to the driver changes: Why not moving to latest 08.05.00.004 release? Already the icssg-prueth driver has several changes there, some of them fixes.

AsuraZeng commented 1 year ago

Hi jan

As described above, TI has published the SDK 08.02.00.002 officially, so I catch up on this version. 08.05.00.004 is on the git repo. this is not officially published

jan-kiszka commented 1 year ago

While continuing the review, my first suggestion for the kernel patch queue would to preserve our original ordering, add the new cherry-picked patches on top. Would allow some bisecting (with some extra setup effort) over the update.

Another suggestion (should be a separate commit) is to use git format-patch --no-signature from now on so that this source of change is consistently avoided. I think you tweaked your format-patch to keep the signature identical, right?

jan-kiszka commented 1 year ago

You dropped these patches from the queue:

This causes a delta of drivers/remoteproc/pru_rproc.c even with your old BSP release baseline.

AsuraZeng commented 1 year ago

While continuing the review, my first suggestion for the kernel patch queue would to preserve our original ordering, add the new cherry-picked patches on top. Would allow some bisecting (with some extra setup effort) over the update.

Another suggestion (should be a separate commit) is to use git format-patch --no-signature from now on so that this source of change is consistently avoided. I think you tweaked your format-patch to keep the signature identical, right?

I have refactored the patches based on your suggestion.

jan-kiszka commented 1 year ago

Please check out https://github.com/siemens/meta-iot2050/commits/jan/kernel-update - there was more to-do than I originally thought.

jan-kiszka commented 1 year ago

Closing as #411 was merged.