siemens / meta-iot2050

SIMATIC IOT2050 Isar/Debian Board Support Package
MIT License
129 stars 76 forks source link

Fix kernel driver crash of icssg_prueth driver upon module removal #445

Closed nhahnetsrot closed 9 months ago

nhahnetsrot commented 1 year ago

Fixes the crash reported in https://github.com/siemens/meta-iot2050/issues/427 .

Allows now the removal / reload of the driver, network devices, links etc. are restored and working.

jan-kiszka commented 1 year ago

Thanks for looking into that! Still, it looks like there are still some todos remaining:

Keep in mind that, mid-term, we would like to get rid of the patch again by sharing our findings with TI and making them adopt them, directly or at least logically. Also for them, we need to explain why we did those changes based on the code, not just the observed stability improvement.

nhahnetsrot commented 1 year ago

Thanks for looking into that! Still, it looks like there are still some todos remaining:

  • resolve the open questions on the fixing patch itself - we really need to understand the issue when trying to fix it
  • write the kernel patch like the patch adding it: subject, commit message, signed-off

Keep in mind that, mid-term, we would like to get rid of the patch again by sharing our findings with TI and making them adopt them, directly or at least logically. Also for them, we need to explain why we did those changes based on the code, not just the observed stability improvement.

TI already knows about this bug ( i emailed with Danish Anwar a0501179@ti.com, he ist responsible for the driver at TI side). He stated that a "cleaned up" version of the driver does not has this issue and will be going into the official kernel "soon". Then this patch is no longer required. (he did not define "soon" ...)

jan-kiszka commented 11 months ago

Will we get an update? Or will this bug have to wait for replacing the patches with their upstream versions?

jan-kiszka commented 9 months ago

Obsoleted by #491