search

siemens / mtda

Multi-Tenant Device Access
Other
36 stars 22 forks source link

feat(www): Enable the usage of modifier keys #408

Closed TobiasSchaffner closed 8 months ago

TobiasSchaffner commented 8 months ago

Expose a press function in the keyboard controller that handles the press of a single key with modifier keys. Use this function from the web UI to allow to hit key combinations like ctrl-c.

Can please somebody test this with qemu? I do not have a running qemu setup atm.

chombourger commented 8 months ago

was traveling this week. I will now take a look, thanks!

chombourger commented 8 months ago

your changes passed the emacs test!

image

let's get the flake8 errors and we will be good to merge this

thank you @TobiasSchaffner !

TobiasSchaffner commented 8 months ago

your changes passed the emacs test!

image

let's get the flake8 errors and we will be good to merge this

thank you @TobiasSchaffner !

Great thanks @chombourger. I changed the maximum line length to 120 chars with an additional commit. Do you prefer to stick to the 80 characters?

chombourger commented 8 months ago

your changes passed the emacs test! image let's get the flake8 errors and we will be good to merge this thank you @TobiasSchaffner !

Great thanks @chombourger. I changed the maximum line length to 120 chars with an additional commit. Do you prefer to stick to the 80 characters?

I’m fine with this, I always found this 80 char max rule silly