siemens / ros-sharp

ROS# is a set of open source software libraries and tools in C# for communicating with ROS from .NET applications, in particular Unity3D
Apache License 2.0
945 stars 364 forks source link

Missing Newtonsoft.Json when setting up ROS# with Unity #409

Closed petpetpeter closed 2 years ago

petpetpeter commented 2 years ago

Here is my question:

I try setting up rossharp on unity by cloning the main branch and found this problem

image

So I check the external library on my previous rossharp project a month ago there is Newtonsoft.Json there

image

Copying these libraries to the external folder in the new project could fix the problem, but there should be a more proper way to fix this so I report a bug here.

MartinBischoff commented 2 years ago

Thank you @petpetpeter for this report and this fix. @ all using an older Unity version: you need to add the Newtonsoft.Json dll as described above to resolve the errors mentioned above. More recent Unity versions already contain a Newtonsoft.Json dll . If we add the same library a second time in the project's asset folder errors occur. This is the reason why we removed it from the master in commit https://github.com/siemens/ros-sharp/commit/6e91309b2447c0919d3dabaa0650bb71e3e490dd.

MartinBischoff commented 2 years ago

further info on Newtonsoft.Json in Unity: