siemens / ros-sharp

ROS# is a set of open source software libraries and tools in C# for communicating with ROS from .NET applications, in particular Unity3D
Apache License 2.0
945 stars 364 forks source link

Update releases to use Semver #429

Closed JohnClema closed 2 years ago

JohnClema commented 2 years ago

I want to do this: ros-sharp was just published to openupm here, however it requires specific versioning in order to be recognised and pulled down using the openupm-cli

For being able to do it, I wish ROS# had the following feature: It was versioned according to semver, openupm requires this as described in package criteria here. This could be achieved by re releasing v1.7 as 1.7.0 or similar.

JohnClema commented 2 years ago

@MartinBischoff is this something that might be possible in future?

MartinBischoff commented 2 years ago

Hi @JohnClema , I just changed all existing releases to refering to semver tags. Please confirm if openupm works for you now. The old non-semver tags are still there. I think about deleting them...

JohnClema commented 2 years ago

Hi @MartinBischoff, it isn't working at the moment due to the old tags. If you see here, the build pipelines are failing for the new ones you published: https://openupm.com/packages/com.siemens.ros-sharp/?subPage=pipelines

I've put in a request over here for openupm to unpublish the old non-semver tags. Let me know what you think! https://github.com/openupm/openupm/issues/3052

MartinBischoff commented 2 years ago

done - I just deleted all old non-semver tags.

JohnClema commented 2 years ago

Thanks @MartinBischoff I'll close this one off and continue finalising this over at https://github.com/openupm/openupm/issues/3052