siemens / sentry-auth-oidc

OpenID Connect SSO provider for Sentry
Apache License 2.0
69 stars 28 forks source link

Dependency missmatch with six #30

Closed Centzilius closed 2 months ago

Centzilius commented 3 years ago

Hi, currently when you try to install sentry-auth-oidc on the latest sentry docker image you get the following version missmatch:

#6 [2/2] RUN pip install sentry-auth-oidc==4.0.1
#6 sha256:fec2e394cfbb519a3dfce598ee28014b2996c8a8b9c0bc69637c144eb76d2c4e
#6 0.857 Collecting sentry-auth-oidc==4.0.1
#6 0.895   Downloading sentry_auth_oidc-4.0.1-py2.py3-none-any.whl (10 kB)
#6 0.938 Collecting six<1.12.0,>=1.11.0
#6 0.945   Downloading six-1.11.0-py2.py3-none-any.whl (10 kB)
#6 0.948 Requirement already satisfied: requests<3.0.0 in /usr/local/lib/python3.6/site-packages (from sentry-auth-oidc==4.0.1) (2.25.1)
#6 0.962 Requirement already satisfied: chardet<5,>=3.0.2 in /usr/local/lib/python3.6/site-packages (from requests<3.0.0->sentry-auth-oidc==4.0.1) (4.0.0)
#6 0.964 Requirement already satisfied: idna<3,>=2.5 in /usr/local/lib/python3.6/site-packages (from requests<3.0.0->sentry-auth-oidc==4.0.1) (2.10)
#6 0.965 Requirement already satisfied: certifi>=2017.4.17 in /usr/local/lib/python3.6/site-packages (from requests<3.0.0->sentry-auth-oidc==4.0.1) (2021.5.30)
#6 0.967 Requirement already satisfied: urllib3<1.27,>=1.21.1 in /usr/local/lib/python3.6/site-packages (from requests<3.0.0->sentry-auth-oidc==4.0.1) (1.24.2)
#6 1.602 Installing collected packages: six, sentry-auth-oidc
#6 1.602   Attempting uninstall: six
#6 1.603     Found existing installation: six 1.16.0
#6 1.604     Uninstalling six-1.16.0:
#6 1.911       Successfully uninstalled six-1.16.0
#6 1.967 ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
#6 1.967 google-cloud-core 1.5.0 requires six>=1.12.0, but you have six 1.11.0 which is incompatible.
#6 1.967 google-api-core 1.25.1 requires six>=1.13.0, but you have six 1.11.0 which is incompatible.
#6 1.967 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#6 1.967 Successfully installed sentry-auth-oidc-4.0.1 six-1.11.0
#6 DONE 2.0s

On first look I did not see what introduced the dependency six<1.12.0,>=1.11.0 but due to the downgrade of six some components of sentry throw an error (not too severe since its apparently only affecting some integrations but it would be nice if that could be resolved).

image

Kind regards, Centzilius

bufferoverflow commented 3 years ago

@Centzilius feel free to provide an MR to fix this. We will look into this later this month.

bufferoverflow commented 3 years ago

@dlouzan @max-wittig as I'm on vacation soon, maybe you could have a look at this?

max-wittig commented 2 months ago

That is fixed since a while now.