search

siemens / simatic-s7-webserver-api

A .NET API Client Library for the SIMATIC S7 PLC Webserver API
https://www.nuget.org/packages/Siemens.Simatic.S7.Webserver.API/
MIT License
107 stars 23 forks source link

Refactor structure (new version will be necessary): Don't double Implement Features "on top" of the "basic" client -> Server functionality #6

Closed KircMax closed 2 years ago

KircMax commented 3 years ago

Refactor structure (new major version will be necessary): Don't double Implement Features "on top" of the "basic" client -> Server functionality => Unify IApiRequestHandler and IAsyncApiRequestHandler to IApiRequestHandler containing async and awaited functionality... => Pack "Extensions" of AsyncApiRequestHandler into Own Handlers => ResourceHandler and PlcProgramHandler

Refactor ThreadSleepTime => Don't sleep in functions either sleep right at the RequestGenerator or maybe use another IdGenerator that implements the wanted features without waiting as long.

github-actions[bot] commented 2 years ago

This is addressed in release v2.0.1.