search

siemiatj / react-native-modal-dropdown

Fork of the original https://github.com/sohobloo/react-native-modal-dropdown
MIT License
119 stars 98 forks source link

Dropdown modal opens to the top now instead of to the bottom #1

Closed donni106 closed 4 years ago

donni106 commented 4 years ago

There was a pull request which changed the top value of the dropdown modal. I already commented there. Since that change, the dropdown modal opens to the top now instead of to the bottom. https://github.com/siemiatj/react-native-modal-dropdown-legacy/pull/1

These lines are effected: https://github.com/siemiatj/react-native-modal-dropdown/blob/9ea6efc570a6ac36f4c625350d8f6edf9dc942ea/components/ModalDropdown.js#L263-L268

I will have a look on the logic and try to find a solution other to reverting the change from the pull request.

deniscreamer commented 4 years ago

The same

siemiatj commented 4 years ago

Merged. Will test more thoroughly later but looks good so far.

QuintonC commented 4 years ago

I'm still experiencing this issue. Was this fix not merged in? It says that it was, but maybe I'm missing something?

donni106 commented 4 years ago

No, the fix is not merged yet.

QuintonC commented 4 years ago

Are there blockers or something? Any way I can help?

donni106 commented 4 years ago

@siemiatj said, that he is busy at his work and tries his best to keep his hands on here.

siemiatj commented 4 years ago

Yeah sorry guys. I'm doing my best and hopefully I can son find some time to fix something by myself. Thanks for the PRs so far !