search

siemiatj / react-native-modal-dropdown

Fork of the original https://github.com/sohobloo/react-native-modal-dropdown
MIT License
119 stars 98 forks source link

RTL support is missing. #43

Open saadi-ninjasCode opened 3 years ago

saadi-ninjasCode commented 3 years ago

App support RTL, but this package is not supporting RTL. As shown in the figure, The modal should be on the left side under the three dots icon but it is still on the right side.

Screenshot 2021-08-27 at 9 56 20 PM

Anyone can help in solving my issue? I want a generic solution as I am using this dropdown in multiple places

Version

Tonyibra commented 2 years ago

updates?

FatmaMahmoud698 commented 2 years ago

any update?

MGEisa96 commented 2 years ago

how did you fix it ?

saadi-ninjasCode commented 2 years ago

how did you fix it ?

I fixed it on my own. I made some changes to this library according to my need.

FatmaMahmoud698 commented 2 years ago

@saadi-ninjasCode can you share with us your updated package?

siemiatj commented 2 years ago

how did you fix it ?

I fixed it on my own. I made some changes to this library according to my need.

If you would submit a PR I can merge this and release in npm.

saadi-ninjasCode commented 2 years ago

@FatmaMahmoud698 , @MGEisa96 , I Submit a PR. If you need any help here is the PR link https://github.com/siemiatj/react-native-modal-dropdown/pull/68