search

sierpinski / Blitz

This repository contains a VSTS extension for showing a list of all active pull requests for a project. This allows users to review open pull requests and click the link to go work the pull request.
https://marketplace.visualstudio.com/items?itemName=sierpinski.blitz-allpulls-extension
Other
24 stars 16 forks source link

Add additional state informationen #7

Open pascalberger opened 8 years ago

pascalberger commented 8 years ago

It would be useful if more state information about the PR can be shown:

pascalberger commented 8 years ago

I don't know if this is possible though with the current API as these information seem to be missing on the gitpullrequest object

pascalberger commented 8 years ago

And related to that is the "Request status" column of any use? Since it only shows active requests anyway won't it always print "Active" there?

IMHO it would be nice to have one flag indicating if the PR is ready to being merged (red / green indicator) with maybe a tooltip showing the details (approval state, policy state)

sierpinski commented 8 years ago

This is a great idea! Brilliant! I will have to research how to get that data, but I love the idea of a single state flag. I'm thinking we load this, and the repository name, after page load asynchronously, so the page loads quickly and slowly updates the page as the info comes in. Thanks by the way for the contributions. I'm just one person, so I love the help!

pascalberger commented 8 years ago

@sierpinski Also maybe using Contextual classes on the table rows to indicate their readiness might be useful.

sierpinski commented 8 years ago

I haven't been able to address most of these yet. I did remove the Request Status field. I also added colors and tooltips on reviewers for now, to indicate how they have responded to the request. When I can, I'll look at the policies to see if we can get that info.

Russweb commented 7 years ago

+1 on those states for me too. To make it really dynamic (not sure if possible or not), but the color-coding would be based on whether all required rules are satisfied. In other words, if it requires a CI build, 2 approvers, and associated work items, then the row is red until all those are met. Does the API have the ability to pick those out yet?

I filed a bug on this: https://connect.microsoft.com/VisualStudio/feedback/details/3111792/tfs-15-rest-api-for-pull-request-missing-overall-status-function