search

sierra-library / sierra

Sierra SCSS library
https://sierra-library.github.io/
GNU General Public License v2.0
858 stars 73 forks source link

Textarea horizontal resize overflows parent #29

Closed Rominou34 closed 8 years ago

Rominou34 commented 8 years ago

Hi, while browsing the home page of your library, I tried resizing a textarea and it actually reacted weirdly

So basically you can resize it both vertically and horizontally, and while vertical resizing is acting normally, horizontal resizing doesn't work as I thought it would: when you release the mouse, the textarea remains the same size ( so it's not overflowing its parent, good ), but the symbol in the bottom right of the textarea on which you click to resize actually stays where you left it

Example I tried puttin max-width: 100% on the .textarea textarea and it actually behaved like I think it should

Note: It's actually my first ever contribution outside my personal projects, sorry if I did it the wrong way.

brianbower commented 8 years ago

It looks like the solution is to add the class textarea to the textarea element (and error) rather than the wrapping div. I'm unsure why in the demo the classes are on the parent element.

JoanClaret commented 8 years ago

Class textarea was on a wrapper div to add posibility to include HTML (for example user image) overlaping the textarea. I did't thought about that. Now is fixed, thanks for sharing this issue!