sierrafoxtrot / srecord

SRecord github Mirror
https://srecord.sourceforge.net/
GNU General Public License v3.0
42 stars 22 forks source link

Add MegaLinter #19

Closed jtxa closed 1 year ago

jtxa commented 1 year ago

Adds a GitHub workflow for MegaLinter with initial configuration and some fixed.

Successful linters:

Switched to be non-blocking:

jtxa commented 1 year ago

I kept the shell script reformatting in separate commits from the changes (for now). For an easier review to decide if the format is now ok (I used some configuration values to match existing formatting as close as possible).

jtxa commented 1 year ago

@sierrafoxtrot Please have a look at the questions above. If you tell me your preference, I can make this PR ready for merge.

sierrafoxtrot commented 1 year ago

Adds a GitHub workflow for MegaLinter with initial configuration and some fixed.

Successful linters:

* JSON: eslint-plugin-jsonc, jsonlint, prettier, v8r

Curious about this one. We don't have any JSON or JS from memory. Does this cover something I'm forgetting?

jtxa commented 1 year ago

The new cSpell configuration is currently a JSON file. But I take a look to convert it to YAML, that way comments can also be added and it might look a bit easier.

sierrafoxtrot commented 1 year ago

The new cSpell configuration is currently a JSON file. But I take a look to convert it to YAML, that way comments can also be added and it might look a bit easier.

I understand. This work is a huge leap forward Josef so happy to keep it as-is if that is the simplest way forward.

jtxa commented 1 year ago

A little polishing done here and there since the first push. The major ones are:

From my side this PR is ready now.

jtxa commented 1 year ago

Rebase to solve conflicts. Also deleted shell/awk/ignore files, obsolete after #22

jtxa commented 1 year ago