search

sierrafoxtrot / srecord

SRecord github Mirror
https://srecord.sourceforge.net/
GNU General Public License v3.0
42 stars 22 forks source link

doc: Useless ref-index.so #21

Closed jtxa closed 1 year ago

jtxa commented 1 year ago

The content of the generated ref-index.so is not used. Even if it's empty, the PDF is identical: same size, same text content, just some bytes are different at the end, some of them being a unique identifier This is a regression of version 1.65.

Found a small extra problem: the last content page in the PDF has number 1000. But this was introduced a long time age (I checked 1.50 and it was already there)

sierrafoxtrot commented 1 year ago

I've removed ref_index.so. Page 1000 looks like a weekend job though

jtxa commented 1 year ago

Just to make sure, that my issue was understood correctly (I should have added a few sentences more): The index has no effect today, but in v1.64 it really appended an index (or so called Table of Contents).

If the removal of the index in v1.65 was on purpose, then removing the script completely is the right solution.

marcows commented 1 year ago

See also comments in 4ae29d8543ac8f6296a79fc7fad42aa62941c6fb

jtxa commented 1 year ago

Yes, that's about the same topic. So the first page of the index is now at page 3 (a good position), and the rest is missing,

I don't how useful the index is at all, for printed books yes, but today....? Especially as these PDFs have no hyperlinks on page numbers.

marcows commented 1 year ago

I don't how useful the index is at all

See short discussion about this at https://github.com/sierrafoxtrot/srecord/pull/11#discussion_r1005509263

sierrafoxtrot commented 1 year ago

I don't see any harm leaving it it and believe it or not, I actually do have a use for the printed copy (although I'm probably in the minority). Hyperlinks would be a nice addition though. I'll look into how that might be done.