search

sierrafoxtrot / srecord

SRecord github Mirror
https://srecord.sourceforge.net/
GNU General Public License v3.0
42 stars 22 forks source link

Fix PDF creation with MSYS2 #28

Closed marcows closed 1 year ago

marcows commented 1 year ago

There were two little regressions which caused the failed/wrong PDF creation. CI only builds documentation using Linux in "QA" workflow, maybe it should be extended, @jtxa?

jtxa commented 1 year ago

About the workflow:

Don't know if it is a long-lasting solution to have the documentation in QA. Perhaps for having the separate steps for every format and for future extra checks (like warning free).

If we want to test packaging on every platform, we need to build also the documentation on every platform. So I suggest we add an additional step ninja package in the existing MSYS2 job, which includes documentation generation.

Until now, I just implemented what worked or I could easily get working. If you have an idea how to solve the solim error, then lets just do it. Please have a look here for the concrete error message.

sierrafoxtrot commented 1 year ago

Until now, I just implemented what worked or I could easily get working. If you have an idea how to solve the solim error, then lets just do it. Please have a look here for the concrete error message.

Regarding the error message, it includes: cmd.exe /C "cd /DD:\a\srecord\srecord\build\doc && sh D:/a/srecord/srecord/doc/script/groff.sh -T ps -man -t -s -I/d/a/srecord/srecord/doc -I/d/a/srecord/srecord/build/doc D:/a/srecord/srecord/doc/etc/README.man > D:/a/srecord/srecord/build/doc/README.pdf.ps.tmp && sh D:/a/srecord/srecord/doc/script/page_select.sh D:/a/srecord/srecord/doc/script/page-list.awk D:/a/srecord/srecord/build/doc/README.pdf.ps.tmp D:/a/srecord/srecord/build/doc/README.pdf.ps && D:\a\srecord\srecord\build\doc\README.pdf.ps D:/a/srecord/srecord/build/doc/README.pdf && rm D:/a/srecord/srecord/build/doc/README.pdf.ps D:/a/srecord/srecord/build/doc/README.pdf.ps.tmp"

This is likely the cause of the failure ie can't find ps2pdf. I can take a look tomorrow if someone else doesn't get to it first.

marcows commented 1 year ago

Until now, I just implemented what worked or I could easily get working. If you have an idea how to solve the solim error, then lets just do it. Please have a look here for the concrete error message.

Regarding the error message, it includes: cmd.exe /C "cd /DD:\a\srecord\srecord\build\doc && sh D:/a/srecord/srecord/doc/script/groff.sh -T ps -man -t -s -I/d/a/srecord/srecord/doc -I/d/a/srecord/srecord/build/doc D:/a/srecord/srecord/doc/etc/README.man > D:/a/srecord/srecord/build/doc/README.pdf.ps.tmp && sh D:/a/srecord/srecord/doc/script/page_select.sh D:/a/srecord/srecord/doc/script/page-list.awk D:/a/srecord/srecord/build/doc/README.pdf.ps.tmp D:/a/srecord/srecord/build/doc/README.pdf.ps && D:\a\srecord\srecord\build\doc\README.pdf.ps D:/a/srecord/srecord/build/doc/README.pdf && rm D:/a/srecord/srecord/build/doc/README.pdf.ps D:/a/srecord/srecord/build/doc/README.pdf.ps.tmp"

This is likely the cause of the failure ie can't find ps2pdf. I can take a look tomorrow if someone else doesn't get to it first.

find_program(PS2PDF ps2pdf) had been removed in https://github.com/jtxa/srecord/commit/322b89ceef6c3c2cef0b2fb011a8fe8386b5eeaf, which was used for the package run.

marcows commented 1 year ago

Until now, I just implemented what worked or I could easily get working. If you have an idea how to solve the solim error, then lets just do it. Please have a look here for the concrete error message.

I tested the workflow steps from your ci-msys2-doc branch locally and don't get soelim errors. But it didn't succeed completely, it failed on step [60/61].

jtxa commented 1 year ago

I solved the soelim problem on the workflow: groff or soelim cannot handle files with CRLF. Tomorrow I'll do a PR which solves that problem and creates packages. It's almost done, just needs polishing.