sierrafoxtrot / srecord

SRecord github Mirror
https://srecord.sourceforge.net/
GNU General Public License v3.0
42 stars 22 forks source link

Migrated code base to use cstdint #48

Closed SeanAlling-DojoFive closed 1 year ago

SeanAlling-DojoFive commented 1 year ago

First pass at using standard types. Looking for feedback if this is something we want to pursue and how far to go.

Addressed comments in #25 and #26

sierrafoxtrot commented 1 year ago

I've been both dreading and looking forward to this change. I actually have a very similar looking branch parked ready to rebase after PR #43 but this looks great so far.

I've only done a quick scan so far, but I'm happy with the approach. Keen to make sure we don't cause any drams with doco etc for a couple changes (for example) from %lu to %u. But in principle, I like the more modern types and it can only help with portability. It's going to take a few days to pour through and highlight any discussion points so please bear with me. Keen to get your input too @jtxa.

It's moments like these I'm grateful for a regression test suite!