search

sierrafoxtrot / srecord

SRecord github Mirror
https://srecord.sourceforge.net/
GNU General Public License v3.0
42 stars 22 forks source link

Ohio Scientific 65A Support #57

Closed chapmajs closed 1 year ago

chapmajs commented 1 year ago

This PR allows SRecord to output data in a format that can be directly input to the Ohio Scientific 65A ROM monitor, which is found on Ohio Scientific 6502 systems with serial console. This is currently output-only, since the dump format for the 65A monitor is substantially different.

Tests are included. The output formatter supports optional execution address.

I can smash this down to a single commit if desired, but left it as multiple commits since one of them does fix a namespace collision with the existing OSI 65V formatter.

chapmajs commented 1 year ago

Pushed changes to fix up automated test errors (linter stuff).

chapmajs commented 1 year ago

A friend suggested that it might be beneficial to read in the OSI 65A output using SRecord, in the event that one had SRecord generated output in a file and needed to turn it into something else. I had some free time today, so I wrote a file input for OSI 65A!

sierrafoxtrot commented 1 year ago

I want to make sure I acknowledge contributions correctly. No dramas at all with Copyright being held by a company but would you like me to mention you by full-name or first-name as well when I pull together the release notes?

Or it could be "contributed by X from Company". Whatever works best for you.

chapmajs commented 1 year ago

No big deal, you can leave it as "Glitch Works, LLC" or do "by Jonathan Chapman from Glitch Works, LLC" -- if you want a point of contact I would prefer you use our site URL (http://www.glitchwrks.com) rather than some internal email address just to help cut down on spam :P

sierrafoxtrot commented 1 year ago

Planning to start a proper review tonight but given the number of commits I'll probably end up doing a squash merge (which I'm perfect happy with and of course it will still show correct attribution). If you wanted to rebase to tease out the work on the OS65A vs OS65V or better reflect history, go right ahead.

chapmajs commented 1 year ago

You can smash it or I can smash it, doesn't matter to me!

chapmajs commented 1 year ago

Alright, requested changes made, and fixed up to appease the clang linter!

chapmajs commented 1 year ago

Thanks!

sierrafoxtrot commented 1 year ago

Thanks for your hard work pulling this together!