gcc 4.3 compilation issues on Ubunty/intrepid

[GoogleCodeExporter]

Gcc have more strinct rules for c++ and asm, so for me it's impossible to
complite GS.cpp, aVif.S and VifDma.S with 4.3 on Ubunty/intrepid.

In GS.cpp it's require to add include <cstring> and <cstdlib> as noted in:
http://gcc.gnu.org/gcc-4.3/porting_to.html

In aVif.S there is movq ops, wich require qword operand (not xmmword, some
of them I think is ZeroG change, so I am not understand the root of
trouble), movd with dword and punpcklwd -- xmmword. 

In VifDma.S there is same trouble with movaps and xmmword.

My svn diff included.

Original issue reported on code.google.com by Zeydl...@gmail.com on 19 Oct 2008 at 3:14

Attachments:

• movq.diff

[GoogleCodeExporter]

Actually, I believe zerofrog was copying an existing patch. As far as the first
issue; that's why I originally had:
#include <stdio.h>
#include <stdlib.h>
#include <string.h>

added to GS.h. I'm using gcc 4.3.1; don't know if 4.3.2 is even more 
problematic...

I don't have the same issue with the *.S files, but I know other people have, 
so I'll
play with the patch, and if it doesn't seem like it's causing any issues, 
commit it
when I have a moment...

Original comment by arcum42@gmail.com on 20 Oct 2008 at 8:01

• Changed title: gcc 4.3 compilation issues on Ubunty/intrepid
• Changed state: Accepted

[GoogleCodeExporter]

Committed, though I had to unbreak the Windows port afterwards. I'll leave this 
open
for a few days, then close as fixed unless anything comes up.

Original comment by arcum42@gmail.com on 21 Oct 2008 at 11:41

• Changed state: Started

[GoogleCodeExporter]

Original comment by arcum42@gmail.com on 23 Oct 2008 at 8:39

• Changed state: Accepted

[GoogleCodeExporter]

Original comment by arcum42@gmail.com on 23 Oct 2008 at 10:11

• Changed state: Fixed