search

sifadil / pcsx2-playground

Automatically exported from code.google.com/p/pcsx2-playground
2 stars 0 forks source link

hasStreamingSIMDExtensions is still with us #35

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
If code for SSE2 check's was removed, than there is a little strange, that
the one for SSE is still with us.

Original issue reported on code.google.com by Zeydl...@gmail.com on 3 Nov 2008 at 3:03

GoogleCodeExporter commented 8 years ago 
At 282 there a few SSE check (cpucaps.hasStreamingSIMDExtensions):
iR5900-64.c, 
  at lines 288, 1081, 1246, 1822

Original comment by Zeydl...@gmail.com on 3 Nov 2008 at 3:15

GoogleCodeExporter commented 8 years ago 
Funny.  I'm pretty sure there that all 64-bit CPUs have SSE2 support.  The fact 
those
checks are even in the i64 recompiler in the first place is pretty amusing.

Original comment by Jake.Stine on 3 Nov 2008 at 3:38

GoogleCodeExporter commented 8 years ago 
Yeah, all "special" pcsx2 configurations haven't been changed yet.
I'd have to reboot to vista64 for that ^^

Original comment by ramapcsx2 on 3 Nov 2008 at 3:49

GoogleCodeExporter commented 8 years ago 
rama> you can always use the "find in files" tool.  Click the little binoculars 
to
the left-side of the Find box on the VS edit toolbar.  Key something in.  It'll 
throw
up every instance of that search item into a "Find in Files"  dialog, and then 
you
can go through line-by-line and fix things.  It's handy to use in conjunction 
with
compiler errors, when making sweeping changes like this one, since it'll find 
code
that is inside #ifdefs and stuff.

Original comment by Jake.Stine on 3 Nov 2008 at 3:53

GoogleCodeExporter commented 8 years ago 
Oh, I know about that (Been working with VS for a year or so :p ).
The problem is just that I want to test the changes before I commit.
And thats only possible on vista64 for me.

Don't worry, I'll do it now :p

Original comment by ramapcsx2 on 3 Nov 2008 at 3:56

GoogleCodeExporter commented 8 years ago

Original comment by ramapcsx2 on 3 Nov 2008 at 3:56

GoogleCodeExporter commented 8 years ago 
Removed the checks from the x64 files. Now only Linux files could have some 
left :p

Original comment by ramapcsx2 on 3 Nov 2008 at 4:32

GoogleCodeExporter commented 8 years ago 
The Linux files, in fact, have the same exact check that the Windows files 
have. Not
surprising; it's pretty obvious that the Linux port was created by taking the 
Windows
version and hacking it. They even both have the same evil defines.

There's also a check in iR5900-64.c, in CPUState, and iR5900-32.c has a check 
to warn
you in ungrammatical english if you don't have SSE in recinit. 

I'm headed out the door, so don't have time to yank those, though...

Original comment by arcum42@gmail.com on 3 Nov 2008 at 9:36

GoogleCodeExporter commented 8 years ago 
So all thats left is the sanity checks then?
I guess we can leave those in, since all they do is tell you that your CPU is 20
years too old to run pcsx2 :p

Original comment by ramapcsx2 on 4 Nov 2008 at 11:09

GoogleCodeExporter commented 8 years ago 
Ok, seems all checks are gone.

Original comment by ramapcsx2 on 5 Nov 2008 at 12:08