search

sifadil / pcsx2-playground

Automatically exported from code.google.com/p/pcsx2-playground
2 stars 0 forks source link

rpropSPECIAL's mult instruction is broken (ir5900Tables.c) #51

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
This problem was discovered in r338, and a fix was attempted in r339.  The
fix works for some games but breaks others.   Portions of Final Fantasy
XII's intro and new game menus are not visible under r339, but display
normally in r338.

A proper fix for this instruction should be devised.  Unfortunately I can't
make heads or tails of the recompiler code so it's gotta be someone else
who figures out the fix for this one. ;)

Original issue reported on code.google.com by Jake.Stine on 20 Nov 2008 at 12:07

GoogleCodeExporter commented 8 years ago 
Aw crap, you're right :/
For me ff12 crashes with vmhack after loading a save as well.

I guess its time to sit down and fix the recent stuff, eh :p

Original comment by ramapcsx2 on 20 Nov 2008 at 9:22

GoogleCodeExporter commented 8 years ago 
Anytime you get a vmhack crash it is usually because _cpuTestTIMR() bees to be 
called
and isn't for some reasons.  Means either it's not called enough (fixed in r348 
tho),
or that it's being called from the wrong spot of cpuBranchTest or something.  
I'll
check it out.

Original comment by Jake.Stine on 20 Nov 2008 at 11:28

GoogleCodeExporter commented 8 years ago 
Alright I fixed my part.  FF12 should load savestates now.  Now I want you to 
go all
fpuRec guru on us and fix that mult instruction! :P

Original comment by Jake.Stine on 20 Nov 2008 at 12:16

GoogleCodeExporter commented 8 years ago 
Issue 44 has been merged into this issue.

Original comment by Jake.Stine on 20 Nov 2008 at 12:26

GoogleCodeExporter commented 8 years ago 
Yeah, sure. I'll do that while rewriting EErec :D
No seriously, the best I can do for now is adding a gamefix that uses the new 
code,
and that defaults to the old (also hacked) code :p

Original comment by ramapcsx2 on 20 Nov 2008 at 1:12

GoogleCodeExporter commented 8 years ago 
Btw, no game loads savestates anymore :/

Original comment by ramapcsx2 on 20 Nov 2008 at 1:13

GoogleCodeExporter commented 8 years ago 
I upped another version, seems to work better :)

Original comment by ramapcsx2 on 20 Nov 2008 at 4:11

GoogleCodeExporter commented 8 years ago 
The problem seems to be resolved :)

Original comment by ramapcsx2 on 5 Dec 2008 at 12:04