sifadil / pcsx2-playground

Automatically exported from code.google.com/p/pcsx2-playground
2 stars 0 forks source link

EE Interpreter is broken since rev 252 #52

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Well, I tried getting it to work again but failed.
This is a job for you, Jake :p

Original issue reported on code.google.com by ramapcsx2 on 20 Nov 2008 at 5:04

GoogleCodeExporter commented 8 years ago
Has to do with this comment:

// EEsCycle update was moved to outside the psxBranchTest.  Since it gets run
// for every branch now, the following code block is obsolete.

Original comment by ramapcsx2 on 20 Nov 2008 at 5:06

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
Yes, dead on.  I checked and the IOP isn't updating the ee cycle delta value, 
so it
just gets stuck in an instant endless loop.  The fix is presumably simple but 
I'm not
somewhere I can compile and run pcsx2.  I'll upload a patch here for you to try 
out
on your end.  Maybe it'll work better than my last attempt at blind code. ;)

Original comment by Jake.Stine on 21 Nov 2008 at 3:36

GoogleCodeExporter commented 8 years ago
Give it a try. :)

Original comment by Jake.Stine on 21 Nov 2008 at 3:54

Attachments:

GoogleCodeExporter commented 8 years ago
Nope, that didn't help.
But its good you know the cause already :)

Original comment by ramapcsx2 on 21 Nov 2008 at 8:13

GoogleCodeExporter commented 8 years ago
A fix for this has been committed in r362.  Please test is a bit more with that
uber-fast machine of yours and see if it has any problems after getting into 
games. 
I was able to go all the way in-game in Disgaea and to the menus in FFXII, but 
at an
avg or 4-6 fps I was starting to grow gray hair. :P

(for the record, the intfix patch I posted was the correct fix except I.. umm..
well... typed '+= 8' instead of '-= 8' in the non-debug version of execI.  
Hahah..
grr >_<)

Original comment by Jake.Stine on 25 Nov 2008 at 5:34

GoogleCodeExporter commented 8 years ago
Oh damnit, these bugs suck :p

Anyway, yeah, interpreters work again. That includes savestates as well :)

Original comment by ramapcsx2 on 25 Nov 2008 at 9:18