sifadil / pcsx2-playground

Automatically exported from code.google.com/p/pcsx2-playground
2 stars 0 forks source link

Add the Speed Hack, Game Fix, and Advanced dialog options to the Linux build. #6

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Add the Speed Hack, Game Fix, and Advanced dialog options to the Linux build.

Don't worry, I'm not expecting anyone else to do this. I'll attach a patch
to this issue once I'm done with it that will add those three dialogs.

I already have a good chunk of it done; I just have to add the logic behind
the Speed Hack and Advanced Dialogs...

Original issue reported on code.google.com by arcum42@gmail.com on 27 Sep 2008 at 8:19

GoogleCodeExporter commented 8 years ago
Everythings implemented, and works *except* that it crashes when it hits 
SetCPUState
in the Advanced Dialog. Close, though...

Original comment by arcum42@gmail.com on 27 Sep 2008 at 10:18

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
Well, once you get it all working I'll gladly integrate your changes.
Till then I'd rather not. No one in this team has / uses Linux, so we all
can't test it.
Bit if you say you have it working in Linux AND it doesn't interfere with 
Windows,
I'll gladly take a patch :)

(Btw, if possible, I'd like a .patch file. The one TortoiseSVN uses, ty :p)

Original comment by ramapcsx2 on 28 Sep 2008 at 2:57

GoogleCodeExporter commented 8 years ago
The current status is that what I've exposed to the user works, it's just that 
the
Advanced menu option is greyed out, so you can't choose it. I just felt that 
even
having the other two dialogs implemented was a major enough improvement that it 
was
worth getting out there, and that it be a while before I figured out what I'm 
missing
with the third.

If you don't agree, that's fine. I'll post again when I've got that dialog 
working. 

And the main reason why I didn't post a patch file is that I generated at least 
one
new header file, and modified practically every file in the folder, including 
an xml
file. I just didn't want to gamble that it'd be able to handle that.

Some of my changes were just cleaning things up; the Linux source code is in a 
fairly
bad state. 

Original comment by arcum42@gmail.com on 28 Sep 2008 at 6:34

GoogleCodeExporter commented 8 years ago
My current code seems to have all three dialogs working, and even saving their 
state
in the Pcsx2.cfg file. I've ironed out a number of bugs, and spent a decent 
amount of
time just changing values and making sure they took in the dialog.

I still need to go through and clean up the code a bit, though. It's got the 
usual
tangles from throwing everything and the kitchen sink at it until everything 
works.

I am leaving the menu items for the Patch Browser and Patch Finder disabled. I 
have
*no* idea why they aren't disabled in the official version, because the 
functions
they call are completely empty.

I'll probably attach a new file tonight or tomorrow.

Original comment by arcum42@gmail.com on 3 Oct 2008 at 2:34

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
Here's an update to fix spelling, and include the Magna Carta hack.

Original comment by arcum42@gmail.com on 10 Oct 2008 at 1:10

Attachments:

GoogleCodeExporter commented 8 years ago
I've deleted the previous patched from here, to make sure they don't get 
accidentally
applied. The one patch I left has been tested in Linux, works, and has all the 
dialog
boxes that have been added in the playground version fully functional.

Original comment by arcum42@gmail.com on 10 Oct 2008 at 1:35

GoogleCodeExporter commented 8 years ago

Original comment by arcum42@gmail.com on 10 Oct 2008 at 12:02

GoogleCodeExporter commented 8 years ago
A version of this patch, slightly revised to standardize the button order with
existing dialog boxes, has been committed. I'd leave this open for the moment, 
in
case any problems crop up.

Original comment by arcum42@gmail.com on 10 Oct 2008 at 9:50

GoogleCodeExporter commented 8 years ago

Original comment by arcum42@gmail.com on 12 Oct 2008 at 7:10