cdvdRead0F() causes slowdown in CD-ROM games

[GoogleCodeExporter]

Since r488, some CD-ROM games run very slow due to frequent call of
GetPS2ElfName() from cdvdRead0F()->cdvdGetDiskType(). Until r488,
GetPS2ElfName() was called in cdvdGetDiskType() only when (needReset == 1).
 I think it will be ok if cdvdGetDiskType() is called once in cdvdReset(),
but anyway please fix in the best way.

Original issue reported on code.google.com by tmkkmac on 29 Dec 2008 at 9:55

Attachments:

• CDVD.cpp.diff

[GoogleCodeExporter]

Thanks for the report.  Sounds fixable. :)
(and I'd also like to visit the same general code for the "games booted through 
bios
report 000000000 CRCs).

Original comment by Jake.Stine on 30 Dec 2008 at 11:30

• Changed state: Started

[GoogleCodeExporter]

This should be fixed in r519.
As it turns out the actual calls to GetPS2ElfName weren't really slowing 
emulation
down much -- that is, I fixed it and the emulator still ran much slower than it
should.  The slowness was more the fault of a bug in the seek code that was 
causing a
lot of unwarranted seek delays when reading sectors.  But calling GetPS2ElfName
during emulation has other potential problems inherent to it, so it was good for
overall emu stability to eliminated the unneeded calls.

Original comment by Jake.Stine on 31 Dec 2008 at 7:36

• Changed state: Fixed

[GoogleCodeExporter]

Thanks, it's playable now.

Original comment by tmkkmac on 31 Dec 2008 at 8:15

[GoogleCodeExporter]

Original comment by Jake.Stine on 31 Dec 2008 at 9:21

• Changed state: Verified