sifiorg / sifi

7 stars 1 forks source link

fix(frontend): temp "loading" Toast type #506

Closed boriskubrik closed 10 months ago

boriskubrik commented 10 months ago

Fixed the type issue by omitting type from ToastOptions in the latest shared-ui build. This PR fixes the TypeScript error so we can continue deploying.

~Can't figure out why the loading prop is not working. ToastType clearly contains it and everything in the shared-ui lib looks fine. Typescript accepts it when passed directly to Toast, but not when used in showToast. The UI works as expected. This PR temporary fixes it so that we can continue deploying.~

Testing

boriskubrik commented 10 months ago

Thanks, @xykota!

Fixed the type issue by omitting type from ToastOptions in the latest shared-ui build. Should be good now.

xykota commented 10 months ago

Rebased to remove the two commits that cancel out