sifis-home / wot-td

Rust crate to produce and consume Web Of Things Thing Descriptions
13 stars 2 forks source link

fix: Avoid problematic serde release #116

Closed lu-zero closed 1 year ago

lu-zero commented 1 year ago

serde 1.0.172 and up rely on opaque non-reproducible binary blobs to function on certain targets, explicitly not providing a library-level opt-out.

This is problematic for some reasons, those that I consider more problematic:

See serde-rs/serde#2538 for the full discussion.

codecov[bot] commented 1 year ago

Codecov Report

Merging #116 (3095e0e) into master (617c9fc) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   97.25%   97.25%   -0.01%     
==========================================
  Files          11       10       -1     
  Lines       13255    13254       -1     
==========================================
- Hits        12891    12890       -1     
  Misses        364      364              

see 1 file with indirect coverage changes

dodomorandi commented 1 year ago

We could close this just because with 1.0.184 the precompiled approach has been reverted.

lu-zero commented 1 year ago

Luckily we can :)