bsousi5
commented
5 years ago Great. And thanks for due diligence.
On May 24, 2019, at 8:20 AM, hsiang-chia.huang notifications@github.com wrote:
@reclusejack commented on this pull request.
In freedom-metal/core_portme.mak https://github.com/sifive/coremark/pull/5#discussion_r287407181:
@@ -32,8 +32,8 @@ OUTFLAG= -o
AS = gas
Flag : CFLAGS
Use this flag to define compiler options. Note, you can add compiler options from the command line using XCFLAGS="other flags"
-PORT_CFLAGS = -O3 -DITERATIONS=3000 -DPERFORMANCE_RUN=1 -DMAIN_HAS_NOARGC=1 -DMAIN_HAS_NORETURN=1 -DHAS_STDIO -DHAS_PRINTF -DHAS_TIME_H -DUSE_CLOCK -FLAGS_STR = "$(PORT_CFLAGS) $(XCFLAGS) $(XLFLAGS) $(LFLAGS_END)" +PORT_CFLAGS = -O3 -DITERATIONS=3000 -DPERFORMANCE_RUN=1 -DMAIN_HAS_NOARGC=1 -DMAIN_HAS_NORETURN=1 -DHAS_STDIO -DHAS_PRINTF -DHAS_TIME_H -DUSE_CLOCK -DHAS_FLOAT=0 +FLAGS_STR = " " Hi Bunnaroath, I've rerun the regression on both RTL and ARTY. We can pass the regression and get the same scores as reported. We can keep the FLAG output for all configs.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/sifive/coremark/pull/5?email_source=notifications&email_token=AIQNVX6OAAMJQ5Y54Y6KXGDPXABSTA5CNFSM4HPGBPRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZUZ6CQ#discussion_r287407181, or mute the thread https://github.com/notifications/unsubscribe-auth/AIQNVXZMW3JZLSRVOMEGVDTPXABSTANCNFSM4HPGBPRA.
To reduce the code size, use library printf function and disable
floating point operation which is used to get the benchmarking time.
Disable compiling flags output because it is too long, please check the
terminal output.