search

sifive / duh-scala

⛏️ DUH component export to Scala
https://github.com/sifive/duh
Apache License 2.0
7 stars 3 forks source link

Properly set the resources on the APBSlaveParameters. #77

Closed richardxia closed 4 years ago

richardxia commented 4 years ago

Fixes #76.

Without setting this, the resources (e.g. memory map information) generated from Diplomacy have no way of attaching to the Diplomacy Device object, which consequently means that neither the Object Model will not be able to serialize the memory map information being onboarded.

In this code snippet, the device variable is in scope due to it being defined elsewhere.

Tested this on an IP block that happens to have an APB slave interface.

richardxia commented 4 years ago

The idea is we will address the other commented out items in separate PRs yes?

That is up to you to decide. I am only trying to fix my immediate issue.

In particular you mention "device is in scope" , is device = device not a reasonable thing to do here?

It is not clear what that device attribute is meant to represent. I had a discussion with @terpstra about this a few months ago where neither of us understand why that is there, or whether it is even being used. I would like to remove it once we understand better what it actually depends on.

richardxia commented 4 years ago

Going to release an 0.15.2 with this bugfix in.