search

sifive / duh-scala

⛏️ DUH component export to Scala
https://github.com/sifive/duh
Apache License 2.0
7 stars 3 forks source link

BundleBridgeSource/Sink need () #83

Closed mwachs5 closed 4 years ago

mwachs5 commented 4 years ago

As of https://github.com/chipsalliance/rocket-chip/commit/8fb3d6f2a1fd4e2e6414c5d290dd6d6b6b06274d#diff-55d088b2df66700b019d92e61edea678R39, BundleBridgeSource and BundleBridgeSink calls need to have parentheses after them or you'll get compile errors (@hcook ?)

e.g. here: https://github.com/sifive/duh-scala/blob/master/lib/export-scala-base.js#L464 Needs to be BundleBridgeSink[...]()

mwachs5 commented 4 years ago

Note: this has been fixed in https://github.com/chipsalliance/rocket-chip/pull/2533 so I think we can close this.