search

sifive / freedom-tools

Tools for SiFive's Freedom Platform
217 stars 52 forks source link

Trace decoder libs #31

Closed bradseevers closed 4 years ago

bradseevers commented 4 years ago

Makefile mods to create position independant code libs on ubuntu for trace decoder.

cgsfv commented 4 years ago

Just updated the freedom-tools Makefile, in case you wanted to try it out.

bradseevers commented 4 years ago

You are ahead of me! I will get to work on this in a few minutes. Thanks!!

-brad

On Thu, Feb 6, 2020 at 2:00 PM Carsten Gosvig notifications@github.com wrote:

Just updated the freedom-tools Makefile, in case you wanted to try it out.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7VM5Y5FJ6VWGTFLO3DRBSCBJA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELA6GWA#issuecomment-583131992, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7RWUBWKCJG6ZR3L4HLRBSCBJANCNFSM4KPIT5LQ .

bradseevers commented 4 years ago

Carsten,,

I have checked in changes to the trace-decoder makefile to support "make install INSTALLPATH=..." I have not yet updated the submodule reference - I am checking freedom-tools out now, and it is SLOW. I will let you know when I get that done.

Thanks,

-brad

On Thu, Feb 6, 2020 at 2:14 PM Brad Seevers brad.seevers@sifive.com wrote:

You are ahead of me! I will get to work on this in a few minutes. Thanks!!

-brad

On Thu, Feb 6, 2020 at 2:00 PM Carsten Gosvig notifications@github.com wrote:

Just updated the freedom-tools Makefile, in case you wanted to try it out.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7VM5Y5FJ6VWGTFLO3DRBSCBJA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELA6GWA#issuecomment-583131992, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7RWUBWKCJG6ZR3L4HLRBSCBJANCNFSM4KPIT5LQ .

bradseevers commented 4 years ago

Carsten,

Last evening I checked in updates to the trace encoder for install support, but I have been unable to update the freedom-tools trace-encoder-libs branch.

Something happened to my copy on my machine, and I have been unable to successfully git it.

Could you do the update? I will continue to attemp to get everything off of github, and if I am successful, I will let you know.

Thanks,

-brad

On Thu, Feb 6, 2020 at 8:08 PM Brad Seevers brad.seevers@sifive.com wrote:

Carsten,,

I have checked in changes to the trace-decoder makefile to support "make install INSTALLPATH=..." I have not yet updated the submodule reference - I am checking freedom-tools out now, and it is SLOW. I will let you know when I get that done.

Thanks,

-brad

On Thu, Feb 6, 2020 at 2:14 PM Brad Seevers brad.seevers@sifive.com wrote:

You are ahead of me! I will get to work on this in a few minutes. Thanks!!

-brad

On Thu, Feb 6, 2020 at 2:00 PM Carsten Gosvig notifications@github.com wrote:

Just updated the freedom-tools Makefile, in case you wanted to try it out.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7VM5Y5FJ6VWGTFLO3DRBSCBJA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELA6GWA#issuecomment-583131992, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7RWUBWKCJG6ZR3L4HLRBSCBJANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

Sure - it's updated now. I will try building again, and let you know how it goes.

bradseevers commented 4 years ago

Thanks Carsten!

-brad

On Fri, Feb 7, 2020 at 8:17 AM Carsten Gosvig notifications@github.com wrote:

Sure - it's updated now. I will try building again, and let you know how it goes.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7TLJTJSELUEJQ7EY4LRBWCRPA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELDSWRI#issuecomment-583478085, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7SC6F2MF53K7CCJAJTRBWCRPANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

With the CROSSPREFIX added to the make install, it builds on ubuntu as well for both linux and windows. In the windows cross build, the bin and lib directories both also has empty linux directories next to the windows directories - it would be nice if it only had the windows directory.

cgsfv commented 4 years ago

Thinking about it, it would be nice if the macos, linux and windows directory levels were removed - making it easier to reference the items.

cgsfv commented 4 years ago

This is also how all the other packages are structured :-)

bradseevers commented 4 years ago

Okay - I will remove the extra level of directories.

-brad

On Fri, Feb 7, 2020 at 9:25 AM Carsten Gosvig notifications@github.com wrote:

This is also how all the other packages are structured :-)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7RPRSVB6SH6JFHWFBDRBWKSLA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELD3MGQ#issuecomment-583513626, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7T2TOB2OAC3S5MB2KDRBWKSLANCNFSM4KPIT5LQ .

bradseevers commented 4 years ago

Okay, changes are pushed to place stuff in bin and lib, and not in bin/$(PLATFORM) and lib/$(PLATFORM).

You will need to update freedom-tool trace-decoder-libs branch to point to latest, as I am still having problems.

Thanks,

-brad

On Fri, Feb 7, 2020 at 9:33 AM Brad Seevers brad.seevers@sifive.com wrote:

Okay - I will remove the extra level of directories.

-brad

On Fri, Feb 7, 2020 at 9:25 AM Carsten Gosvig notifications@github.com wrote:

This is also how all the other packages are structured :-)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7RPRSVB6SH6JFHWFBDRBWKSLA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELD3MGQ#issuecomment-583513626, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7T2TOB2OAC3S5MB2KDRBWKSLANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

Great - I will update trace-decoder in freedom-tools.

One more request - I would like you to rename NEWLIBPATH to BINUTILSPATH, as that is what it really points to.

bradseevers commented 4 years ago

Okay - give me a few minutes and I will!

-brad

On Fri, Feb 7, 2020 at 11:14 AM Carsten Gosvig notifications@github.com wrote:

Great - I will update trace-decoder in freedom-tools.

One more request - I would like you to rename NEWLIBPATH to BINUTILSPATH, as that is what it really points to.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7T3M7I6HLUMOAP4TLTRBWXJ5A5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELEG7QY#issuecomment-583561155, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7V3VWNMLQPLWEWV5FLRBWXJ5ANCNFSM4KPIT5LQ .

bradseevers commented 4 years ago

Message failed to send. I updated the trace-decoder makefiles for the BINUTILSPATH. Can you update freedom-tools to point to it? And use the BINUTILSPATH when building the trace decoder?

Thanks,

-brad

On Fri, Feb 7, 2020 at 11:14 AM Carsten Gosvig notifications@github.com wrote:

Great - I will update trace-decoder in freedom-tools.

One more request - I would like you to rename NEWLIBPATH to BINUTILSPATH, as that is what it really points to.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7T3M7I6HLUMOAP4TLTRBWXJ5A5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELEG7QY#issuecomment-583561155, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7V3VWNMLQPLWEWV5FLRBWXJ5ANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

It builds fine on both ubuntu (incl. cross windows) and mac. I add a binutils build step to the trace-decoder package build in freedom-tools, so that the trace-decoder can be built alone, simply by: make trace-decoder

bradseevers commented 4 years ago

Looks good Carsten!

Thanks,

-brad

On Fri, Feb 7, 2020 at 4:25 PM Carsten Gosvig notifications@github.com wrote:

It builds fine on both ubuntu (incl. cross windows) and mac. I add a binutils build step to the trace-decoder package build in freedom-tools, so that the trace-decoder can be built alone, simply by: make trace-decoder

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7XS4T34PYEKVU5IYXTRBX3YHA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELFCJNI#issuecomment-583673013, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7W2ZOCSW7G7L24WODTRBX3YHANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

And now it also builds on Centos6.

bradseevers commented 4 years ago

Thats great! Does that mean we are done and it can be merged into master?

-brad

On Fri, Feb 7, 2020 at 5:18 PM Carsten Gosvig notifications@github.com wrote:

And now it also builds on Centos6.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7TWLRX5UHPIPDGNPWTRBYB53A5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELFEPXI#issuecomment-583682013, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7S5HTPW7JEMLFOZSJTRBYB53ANCNFSM4KPIT5LQ .

cgsfv commented 4 years ago

Yes, I think we should merge it master. But all the packages built needs to be tested on all the platforms before we can say we are done.

bradseevers commented 4 years ago

Sounds good Carsten!

On Fri, Feb 7, 2020 at 10:31 PM Carsten Gosvig notifications@github.com wrote:

Yes, I think we should merge it master. But all the packages built needs to be tested on all the platforms before we can say we are done.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sifive/freedom-tools/pull/31?email_source=notifications&email_token=ALEGT7QUM6JKYRQUUN2775LRBZGSPA5CNFSM4KPIT5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELFK57I#issuecomment-583708413, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEGT7XF7N2IRKPQRVU45GDRBZGSPANCNFSM4KPIT5LQ .