search

sifive / wit

Workspace Integration Tool
Apache License 2.0
23 stars 13 forks source link

Add a `wit clean` command #189

Open richardxia opened 4 years ago

richardxia commented 4 years ago

Sometimes when you update a wit package, it may no longer depend on some transitive package, but wit will leave that package in the workspace. Adding a wit clean command that is analogous to git clean would be helpful for removing these untracked packages.

Since it is a dangerous command, I think requiring the -f flag, similar to git clean, would be a good idea.

mwachs5 commented 4 years ago

would this also do what git clean does and delete untracked files? Or is the idea to use git clean for that?

richardxia commented 4 years ago

I was thinking that this would only clean wit packages, not any untracked files within the wit packages. I hadn't considered that one might conflate wit clean with git clean, so perhaps that's reason enough to use a different verb. Maybe wit clean-pkg, to match the other *-pkg commands?

mwachs5 commented 4 years ago

yeah that makes sense based on my limited exposure to wit

On Fri, Dec 13, 2019 at 11:58 PM Richard Xia notifications@github.com wrote:

I was thinking that this would only clean wit packages, not any untracked files within the wit packages. I hadn't considered that one might conflate wit clean with git clean, so perhaps that's reason enough to use a different verb. Maybe wit clean-pkg, to match the other *-pkg commands?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sifive/wit/issues/189?email_source=notifications&email_token=AEIIAJHDZ2LXD5Q62FEJSIDQYSG37A5CNFSM4J2Y6RP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG34X7I#issuecomment-565693437, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIIAJF5ECMEPLBQFEICB5DQYSG37ANCNFSM4J2Y6RPQ .

-- Megan A. Wachs VP of Engineering | SiFive, Inc 1875 South Grant Street Suite 600 San Mateo, CA 94402 megan@sifive.com