search

sifive / wit

Workspace Integration Tool
Apache License 2.0
23 stars 13 forks source link

Add /bin/bash to github actions docker container #236

Closed mmjconolly closed 4 years ago

mmjconolly commented 4 years ago

Since we moved our actions docker container to alpine linux, we should use /bin/sh instead of bash

mmjconolly commented 4 years ago

I haven't actually tested it yet

mmjconolly commented 4 years ago

I kinda think life is easier if we require all images to have /bin/bash

richardxia commented 4 years ago

I kinda think life is easier if we require all images to have /bin/bash

Yeah, I think that is not a terrible thing to add. Alternatively, we could write this in Python given that we already depend on Python? But probably faster and fine to just install bash into the Docker image.

mmjconolly commented 4 years ago

Adding /bin/bash instead

richardxia commented 4 years ago

Sorry, I should have paid closer attention. You actually need to add bash to the Dockerfile corresponding to the GitHub Action, not wit's own Dockerfile.

mmjconolly commented 4 years ago

My hunch is that it's because we have FROM sifive/wit:v0.13.0 in actions/wit/Dockerfile, where 0.13 is older than where we added bash