search

sigal-raab / Motion

Motion classes, based on Holden's code http://theorangeduck.com/page/deep-learning-framework-character-motion-synthesis-and-editing
24 stars 3 forks source link

What are offsets? #2

Closed lassemt closed 1 year ago

lassemt commented 1 year ago

Hi Sigal, thank you for providing a good solution for exporting BVH from Motion Diffusion Model output. I've been experimenting with it to learn more about the motion format.

In animation_from_positions I noticed there is an optional parameter called offsets: https://github.com/sigal-raab/Motion/blob/3abc6e3e2c20f53f0e682f6bb2b658adb4c13563/InverseKinematics.py#L520 Is this a parameter where I can provide default bone offsets that is used when calculating joint positions to rotations? For example offsets from bones in the default T-pose?

Best regards Lasse

sigal-raab commented 1 year ago

Is this a parameter where I can provide default bone offsets that is used when calculating joint positions to rotations? For example offsets from bones in the default T-pose?

Yes!

lassemt commented 1 year ago

Awesome! And it looks I can use the offsets from existing bvh with BVH.load function. Thank you!