sigdba / sig-shared-sceptre

Shared templates for Sceptre/CloudFormation
2 stars 0 forks source link

Health check path not being set for EcsWebService #63

Closed dboitnot closed 2 years ago

dboitnot commented 2 years ago
      rules:
        - path: /BannerExtensibility
          host: banner-test.*
          health_check:
            path: /BannerExtensibility/actuator/health

Produces:

    TargetGroupFORSLASHBannerExtensibilitySLASH:
      Properties:
        HealthCheckIntervalSeconds: 60
        HealthCheckPath: /BannerExtensibility/
        HealthCheckProtocol: HTTP
        HealthCheckTimeoutSeconds: 30

Instead of:

        HealthCheckPath: /BannerExtensibility/actuator/health
dboitnot commented 2 years ago

Note that the fix also adds an improvement to the way things are titled and labeled. Where we'd previously used the health-check path we're now using the rule path when available.

dboitnot commented 2 years ago

Addressed in release 102.