sigdba / sig-shared-sceptre

Shared templates for Sceptre/CloudFormation
2 stars 0 forks source link

Error when specifying hostname and hosted_zone_id #77

Closed dboitnot closed 1 year ago

dboitnot commented 1 year ago

In release 111 of MultihostElb we get an error when adding a hostname with a hosted_zone_id to a listener:

    - port: 443
      hostnames:
        - wiki.ban.sig.sh
        - tools.ban.sig.sh
        - hostname: gitlab.sigcorp.com
          hosted_zone_id: Z2R0LYB2ABC123

Throws:

  File "/repo/test/templates/MultihostElb/main.py", line 686, in elb_cnames
    efn("CNAME", fqdn, Sub("${LoadBalancer.DNSName}."), hosted_zone_id=zone_id)
  File "/repo/test/templates/MultihostElb/main.py", line 653, in ret
    return ns_entry_route53(
TypeError: ns_entry_route53() missing 1 required positional argument: 'value'
dboitnot commented 1 year ago

Fixed in r114.