search

sigflup / Mega-Happy-Sprite

A sega genesis /megdrive sprite/scrollplane editor
http://theadesilva.com/mega
BSD 3-Clause "New" or "Revised" License
15 stars 3 forks source link

Windows workflow was broken. #4

Open bitRAKE opened 3 days ago

bitRAKE commented 3 days ago

Windows doesn't have autoconf. So, a substitute is needed that is compatible with the workflow. Deleting the configured makefile is what broke the workflow. Perhaps putting it back would resolve the situation, but that isn't flexible going forward perhaps?

sigflup commented 3 days ago

Sure. Let's put back the windows makefile.

On Mon, Nov 18, 2024, 11:19 PM Rickey Bowers Jr. @.***> wrote:

Windows doesn't have autoconf. So, a substitute is needed that is compatible with the workflow. Deleting the configured makefile is what broke the workflow. Perhaps putting it back would resolve the situation, but that isn't flexible going forward perhaps?

— Reply to this email directly, view it on GitHub https://github.com/sigflup/Mega-Happy-Sprite/issues/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEUJT3XUNXUWOCWYKOPIFD2BLC65AVCNFSM6AAAAABSBHCH5KVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY3TANZYGU3TSMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

sigflup commented 3 days ago

I'm going to bed now. I'll talk to you later

On Mon, Nov 18, 2024, 11:39 PM sigflup synasloble @.***> wrote:

Sure. Let's put back the windows makefile.

On Mon, Nov 18, 2024, 11:19 PM Rickey Bowers Jr. @.***> wrote:

Windows doesn't have autoconf. So, a substitute is needed that is compatible with the workflow. Deleting the configured makefile is what broke the workflow. Perhaps putting it back would resolve the situation, but that isn't flexible going forward perhaps?

— Reply to this email directly, view it on GitHub https://github.com/sigflup/Mega-Happy-Sprite/issues/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEUJT3XUNXUWOCWYKOPIFD2BLC65AVCNFSM6AAAAABSBHCH5KVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY3TANZYGU3TSMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

sigflup commented 3 days ago

I'll rebuild configure tomorrow to reflect that there's no Makefile.windows.in just Makefile.windows

On Mon, Nov 18, 2024, 11:41 PM sigflup synasloble @.***> wrote:

I'm going to bed now. I'll talk to you later

On Mon, Nov 18, 2024, 11:39 PM sigflup synasloble @.***> wrote:

Sure. Let's put back the windows makefile.

On Mon, Nov 18, 2024, 11:19 PM Rickey Bowers Jr. < @.***> wrote:

Windows doesn't have autoconf. So, a substitute is needed that is compatible with the workflow. Deleting the configured makefile is what broke the workflow. Perhaps putting it back would resolve the situation, but that isn't flexible going forward perhaps?

— Reply to this email directly, view it on GitHub https://github.com/sigflup/Mega-Happy-Sprite/issues/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEUJT3XUNXUWOCWYKOPIFD2BLC65AVCNFSM6AAAAABSBHCH5KVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY3TANZYGU3TSMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

bitRAKE commented 2 days ago

How does autoconf function? Are there default settings?

MSYS2 supports autoconf, we can add it to the install ...

        install: >-
           msys/vim
           msys/base-devel
           msys/autoconf

... and change the build step if autoconf will create the needed files for windows. IIRC, it wasn't part of the prior Windows workflow - it can be though.

    - name: Build
      run: |
        configure
        make -f Makefile.windows

... perhaps some experimentation is need to discovery what is happening or how to get autoconf to do what is needed. I'm just not familiar with the tool.

sigflup commented 2 days ago

To be out Honest autoconf doesn't do much. I think I'm going to drop it and just go with makefiles

On Tue, Nov 19, 2024, 2:56 PM Rickey Bowers Jr. @.***> wrote:

How does autoconf function? Are there default settings?

MSYS2 supports autoconf, we can add it to the install ...

    install: >-           msys/vim           msys/base-devel           msys/autoconf

... and change the build step if autoconf will create the needed files for windows. IIRC, it wasn't part of the prior Windows workflow - it can be though.

- name: Build
  run: |        configure        make -f Makefile.windows

... perhaps some experimentation is need to discovery what is happening or how to get autoconf to do what is needed. I'm just not familiar with the tool.

— Reply to this email directly, view it on GitHub https://github.com/sigflup/Mega-Happy-Sprite/issues/4#issuecomment-2486735374, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEUJT54OVPJZD3WGGSQXDL2BOQXJAVCNFSM6AAAAABSBHCH5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBWG4ZTKMZXGQ . You are receiving this because you commented.Message ID: @.***>

bitRAKE commented 2 days ago

In that regard the Windows build will need all the files generated presently by autoconf.

sigflup commented 2 days ago

The makefile and config.h is what autoconf generates

On Tue, Nov 19, 2024, 3:02 PM Rickey Bowers Jr. @.***> wrote:

In that regard the Windows build will need all the files generated presently by autoconf.

— Reply to this email directly, view it on GitHub https://github.com/sigflup/Mega-Happy-Sprite/issues/4#issuecomment-2486745440, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEUJT3MEFHI2TV2FU655Y32BORN3AVCNFSM6AAAAABSBHCH5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBWG42DKNBUGA . You are receiving this because you commented.Message ID: @.***>

sigflup commented 2 days ago

I just checked. None of the code uses anything from config.h. I'm Going remove autotools. Does that sound ok?

On Tue, Nov 19, 2024, 3:04 PM sigflup synasloble @.***> wrote:

The makefile and config.h is what autoconf generates

On Tue, Nov 19, 2024, 3:02 PM Rickey Bowers Jr. @.***> wrote:

In that regard the Windows build will need all the files generated presently by autoconf.

— Reply to this email directly, view it on GitHub https://github.com/sigflup/Mega-Happy-Sprite/issues/4#issuecomment-2486745440, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEUJT3MEFHI2TV2FU655Y32BORN3AVCNFSM6AAAAABSBHCH5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBWG42DKNBUGA . You are receiving this because you commented.Message ID: @.***>

bitRAKE commented 2 days ago

Presently, config.h doesn't exist but Makefile.windows references it. Removing those references might fix the workflow build.

I'm really in the dark here. I haven't been following the code base, tbh. If these things are not part of future development then they do seem superfluous. If it's a future direction the potential exists to adapt the workflow.

sigflup commented 2 days ago

Ok. I'm going to get rid of autotools now

On Tue, Nov 19, 2024, 3:50 PM Rickey Bowers Jr. @.***> wrote:

Presently, config.h doesn't exist but Makefile.windows references it. Removing those references might fix the workflow build.

I'm really in the dark here. I haven't been following the code base, tbh. If these things are not part of future development then they do seem superfluous. If it's a future direction the potential exists to adapt the workflow.

— Reply to this email directly, view it on GitHub https://github.com/sigflup/Mega-Happy-Sprite/issues/4#issuecomment-2486823659, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEUJT56UJMIVVVHGTHGBMT2BOXCRAVCNFSM6AAAAABSBHCH5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBWHAZDGNRVHE . You are receiving this because you commented.Message ID: @.***>