siggame / coliselia

Common components & services between ophelia and colisee; note: repo name subject to change
3 stars 1 forks source link

Create Schedule Table in Database #8

Closed russleyshaw closed 7 years ago

russleyshaw commented 7 years ago

File: /db/init.sql

The scheduling functionality will basically work by having each played game reference a schedule column in the database.

Prefer to set NOT NULL with sensible default, over nullable with no default, over NOT NULL with no default Booleans should typically be not null with default

child of #1

russleyshaw commented 7 years ago

Minor things I noticed

make data and result NULLable make include_all DEFAULT to false (include_all would override other settings) Make type not have a default. The type is pretty important and would have adverse effects if initiaalized to something by default by accident

russleyshaw commented 7 years ago

Fixed in #11