search

siggame / octo-robot

The Legacy Arena
2 stars 0 forks source link

gladiator fails to run correctly #39

Closed DanielBolef closed 8 years ago

DanielBolef commented 8 years ago

So, I'm not sure about this one, I don't know what the error means:

daniel17sep@daniel17sep-Lenovo-G570:~/Documents/gladiators-checkers$ bash ./kick.sh daniel17sep@daniel17sep-Lenovo-G570:~/Documents/gladiators-checkers$ processing game 32 Making /home/daniel17sep/Documents/gladiators-checkers/1/python_checkers4 result for make in python_checkers4 was True Making /home/daniel17sep/Documents/gladiators-checkers/1/python_checkers5 result for make in python_checkers5 was True /home/daniel17sep/Documents/gladiators-checkers/Cerveau/gameplay/lobby.js:208 var numberOfPlayers = this.getClientsPlaying(gameSession.clients).length; ^

TypeError: Cannot read property 'clients' of undefined at Object.Class._isGameSessionOpen (/home/daniel17sep/Documents/gladiators-checkers/Cerveau/gameplay/lobby.js:208:69) at Object.Class.getRequestedGameSession (/home/daniel17sep/Documents/gladiators-checkers/Cerveau/gameplay/lobby.js:107:26) at Object._authenticator.authenticate.success (/home/daniel17sep/Documents/gladiators-checkers/Cerveau/gameplay/lobby.js:232:40) at Object.Class.authenticate (/home/daniel17sep/Documents/gladiators-checkers/Cerveau/gameplay/authenticator.js:40:18) at Object.Class._clientSentPlay (/home/daniel17sep/Documents/gladiators-checkers/Cerveau/gameplay/lobby.js:227:29) at Object.Class.clientSentData (/home/daniel17sep/Documents/gladiators-checkers/Cerveau/gameplay/server.js:73:26) at Socket.socketListenerOnData (/home/daniel17sep/Documents/gladiators-checkers/Cerveau/gameplay/client.js:55:29) at emitOne (events.js:77:13) at Socket.emit (events.js:169:7) at readableAddChunk (_stream_readable.js:146:16) running... 32 *** die 6792 *** die 6794 pushing data blocks... 32 game 32 early termination, broken client

JacobFischer commented 8 years ago

Is the gladiator trying to run a client, or the server?

Because that is server code breaking, though I'm not sure why.

DanielBolef commented 8 years ago

It should be running the server.

JacobFischer commented 8 years ago

can you try running the server with the --print-tcp command? so:

node main.js --arena --print-tcp

This will print all TCP socket i/o so I can see what the clients and server are talking about.

DanielBolef commented 8 years ago

--print-tcp had no effect

JacobFischer commented 8 years ago

it shouldn't change the way the server works, but it should print to stdio the tcp communication between the server and client, so I can see how they talk. Can you attach the console output?

DanielBolef commented 8 years ago

I mean it didn't output anything more than it did before.

JacobFischer commented 8 years ago

Lame. I'll probably need to add verbose print statements to figure out what's broke. Friday during code sprint?

DanielBolef commented 8 years ago

I can be there.

JacobFischer commented 8 years ago

Hey I think I figured it out.

Basically the arena has the clients send which game session IDs to join. That actually wasn't working on the server, causing the errors you described. I've fixed in in the most recent commit siggame/Cerveau@7fa4656c08206ef17002e5ebeab81ce44c65c7e5.

So have the arena pull and see if we can close this issue.