search

sighjs / sigh

multi-process expressive build system for the web and node.js, built using baconjs observables
209 stars 12 forks source link

Support for writing file encodings. #14

Closed Flaise closed 8 years ago

Flaise commented 8 years ago

Previously, Sigh would corrupt .png, .ogg, .gif files and the like when copying them. Adding an option for file encoding solves this. Requires https://github.com/sighjs/sigh-core/pull/2

Flaise commented 8 years ago

With the exception of the test I added that depends on another PR, I don't understand why that's not working on your CI server. It works fine on my machine.

insidewhy commented 8 years ago

Hm, maybe the patch doesn't work in earlier versions of node? Sorry for being so unresponsive, I'm terribly busy this week, next week I'll have some time to get back on top of all my open source commitments :+1: :baby_chick:

insidewhy commented 8 years ago

If the tests depend on a later sigh-core, the CI server wouldn't have access to that change. That's probably it. So let's get that one merged first and then I'll refresh the CI server build.

Flaise commented 8 years ago

Yes, I had to make the two changes together. This PR doesn't work without the other and the other is useless without this one.

insidewhy commented 8 years ago

Published version 0.12.26 with this, sorry for taking so long.