sighjs / sigh

multi-process expressive build system for the web and node.js, built using baconjs observables
209 stars 12 forks source link

Cannot run `sigh command` from project root on Windows #15

Open unlight opened 9 years ago

unlight commented 9 years ago

Project root contains sigh.js. If I type sigh it opens sigh.js in editor, but not launches binary from global npm bin (ex. c:\ProgramData\chocolatey\lib\nodist\bin\sigh.cmd) To prevent this I must type sigh.cmd, which is not really convenient. Other projects have convention project + file: makefile, gulpfile.js, gruntfile.js, etc.

insidewhy commented 9 years ago

What shell is this? That behaviour is not normal. Please reopen with more info. AFAIK for node stuff it's best to use bash/zsh via something like cygwin.

unlight commented 9 years ago

What shell is this?

Standard windows cmd. But everything works in PowerShell. See https://youtu.be/8wGudYFwkik

insidewhy commented 9 years ago

cmd is awful, I don't care to support it. Everyone should be using a better shell by now. So apparently cmd is not as terrible as it was when I last had windows installed 20 years ago... guess this has to be supported then.

enzy commented 9 years ago

cmd is awful, I don't care to support it. Everyone should be using a better shell by now.

@ohjames cmd in Windows 10 is pretty usable, fast and native. All Node.js ecosystem runs on it. In contrast to Cygwin bash which is awfully slow and causes unexpected errors.

It is a clearly a bug in your invocation handling, not cmd itself.

insidewhy commented 9 years ago

Thanks for the info, haven't been keeping up with windows in a while, but I do have windows 10. I haven't found cygwin zsh to be slow or buggy though even on my slow HP stream. I guess cmd can be reconfigured to recognise sigh as a pattern in addition to *file.js but maybe I can offer that pattern as an alternative.

insidewhy commented 8 years ago

I dunno, it seems to me that it's cmd flying in the face of everything else here. I wouldn't want me setup to automatically convert blah into $EDITOR blah.${whatever extension blah has}, it seems weird that's the cmd default.

insidewhy commented 8 years ago

Will move to sighfile.js in release 0.13 and support sigh.js with a deprecation notice until 0.14

insidewhy commented 8 years ago

Does anyone here actually host node projects on windows servers? Or develop on windows even when using Linux servers?

enzy commented 8 years ago

Or develop on windows even when using Linux servers

of course we do

insidewhy commented 8 years ago

of course we do

I meant directly on windows... not using a linux VM or docker for windows.

I would have assumed that developers who use windows would want their development environment to reflect the server environment as closely as possible.

insidewhy commented 8 years ago

Every project I've lead... the first thing I do is set up a vagrant "boot to docker" VM, and then set up a development container.

Expecting all the developers on my project to maintain the required versions, libraries and setups across a diverse set of base systems seems like too much to ask.

insidewhy commented 8 years ago

And I guess I'd much rather encourage this type of practice than worry about sigh on windows given my current list of priorities (although if anyone want to submit a PR I'd be more than happy to merge it).

insidewhy commented 8 years ago

When I do release v0.13 I will migrate to Sighfile.js since it's so easy but there may be other issues preventing things working well on windows.

iTob191 commented 8 years ago

Other things like sighjs/sigh-cli#6 ? :p