search

sighjs / sigh

multi-process expressive build system for the web and node.js, built using baconjs observables
209 stars 12 forks source link

Pass through options to node-glob #37

Closed jmatsushita closed 8 years ago

jmatsushita commented 8 years ago

This is related to why I bumped into #36

It would be good to pass the Options object key/values that are not Sigh specific down to node-glob options.

In particular I'd like to have access to the 'ignore' option since otherwise (as far as I know) there is unnecessary walking at the globbing stage to exclude folders or files - if they needs to then be rejected afterwards with the sigh-reject/filter module.

insidewhy commented 8 years ago

It might be better to add the option to the plugin and support each one explicitly, otherwise it will not be possible to switch out the glob implementation at a later date.

insidewhy commented 8 years ago

Will close this for now, can open more specific issues for desired features.

jamesj2 commented 8 years ago

Being able to pass the options to the node-glob is needed for ignoring specific patterns. You can use select() to filter out the unwanted files but chokidar won't be filtered. What about moving the watcher to it's own plugin so that users can supply their own options?

insidewhy commented 8 years ago

I'm definitely open to a PR to add filter patterns, it's also fine to write other glob plugins that exist as plugins.

insidewhy commented 8 years ago

Other plugins can check if -w was used to implement their own watch behaviour.